This repository was archived by the owner on May 15, 2026. It is now read-only.
Fix Orchestrator task persistence and file lock handling - #10957
Draft
ghost wants to merge 1 commit into
Draft
Conversation
- Increase lock staleness timeout from 31s to 60s for complex orchestrator scenarios - Increase lock retries from 5 to 10 with higher backoff timeouts (200ms-2s) - Add retry logic (3 attempts) for critical parent task metadata persistence - Add user-visible warnings when delegation metadata persistence fails - Improve error messages with context about lock contention causes This addresses issues where Orchestrator mode tasks would disappear from the task list after creating multiple subtasks in rapid succession, caused by lock contention during concurrent file writes.
Author
Review complete. No issues found. The changes appropriately address lock contention during rapid orchestrator delegation by:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where Orchestrator mode tasks would stop prematurely and disappear from the task list after creating multiple subtasks in rapid succession.
Root Cause
Lock contention during rapid file writes when Orchestrator creates multiple subtasks. Each delegation involves concurrent writes to:
When lock acquisition failed or metadata persistence failed silently, parent tasks would appear to "disappear" from the UI.
Changes
Increased lock resilience in safeWriteJson:
Added retry logic for critical delegation metadata:
Testing
View task on Roo Code Cloud
Important
Enhances task persistence and lock handling in Orchestrator mode by adding retry logic and increasing lock resilience in
ClineProvider.tsandsafeWriteJson.ts.ClineProvider.ts.safeWriteJson.tswith longer timeouts and more retries.safeWriteJson.ts: Lock staleness timeout increased from 31s to 60s, retries from 5 to 10, and backoff timeout range from 100-1000ms to 200-2000ms.ClineProvider.ts: 3 retry attempts with exponential backoff for parent task status persistence.safeWriteJsontests pass (16/16).This description was created by
for 8a5eccb. You can customize this summary. It will automatically update as commits are pushed.